Got it - so GWT is consistent, but the jetty vers we use talks about a 
different one, and our ant process should ignore what jetty asks for in 
favor of our copy.

Filipe, here's the case, in a super-minimal pom, which will fail outright 
without any sources, just a dependency on gwt-dev and the enforcer to 
prevent any conflicts in dependencies:

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0";
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
  <modelVersion>4.0.0</modelVersion>


  <groupId>sample</groupId>
  <artifactId>sample</artifactId>
  <version>0.0.1-SNAPSHOT</version>
  <dependencies>
    <dependency>
      <groupId>com.google.gwt</groupId>
      <artifactId>gwt-dev</artifactId>
      <version>2.8.0-SNAPSHOT</version>
    </dependency>
  </dependencies>


  <repositories>
    <repository>
      <id>google-snapshots</id>
      <url>https://oss.sonatype.org/content/repositories/google-snapshots/
</url>
      <snapshots>
        <enabled>true</enabled>
      </snapshots>
    </repository>
  </repositories>


  <build>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-enforcer-plugin</artifactId>
        <version>1.4.1</version>
        <executions>
          <execution>
            <id>enforce</id>
            <configuration>
              <rules>
                <dependencyConvergence/>
              </rules>
            </configuration>
            <goals>
              <goal>enforce</goal>
            </goals>
          </execution>
        </executions>
      </plugin>
    </plugins>
  </build>
</project>


Build log including grabbing latest gwt:
https://gist.github.com/niloc132/5cf8162ccc3503215f12d151f4c03168

Patch is done, will have it up soon after a bit more poking.

On Friday, April 29, 2016 at 4:38:15 AM UTC-5, Thomas Broyer wrote:
>
>
>
> On Thursday, April 28, 2016 at 11:47:48 PM UTC+2, Colin Alworth wrote:
>>
>> I didn't know how hard and fast we could rely on ASM's backward compat 
>> being.
>>
>
> This is true since ASM 4.0 (released in 2011): 
> http://download.forge.objectweb.org/asm/asm4-guide.pdf
> Fortunately, they changed the groupId for ASM 4.0, so you can safely 
> "converge" to the latest version for org.ow2.asm dependencies, and you 
> should *ban* asm:asm dependencies (ASM 3 and earlier, having no backwards 
> compatibility contract, should have been repackaged –as was done in earlier 
> versions of GWT– rather than simply referenced –as many unfortunately did 
> in earlier versions, such as Hibernate, Jetty, etc.–)
>  
>
>> Probably should also put this in tools so that we are consistent, and 
>> update the ant files so that we don't get slightly different classes in 
>> maven vs zip archive...
>>
>
> We have 5.0.3 in tools, and Maven will "converge" to 5.0.3, so we're 
> consistent. Or am I missing something? (or didn't understand what you're 
> saying)
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/487990c1-dfb3-4fc9-88a5-4fa667f25f1a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to