Sorry, the change is at https://gwt-review.googlesource.com/#/c/8041/


On Friday, July 22, 2016 at 4:13:38 PM UTC-7, Kay Pac wrote:
>
> In change 580db4248fc38f9721d0a920cabfc2b17e10d73f (
> http://gwt-code-reviews.appspot.com/1113801/show), the constructor for 
> SerializableTypeOracleBuilder was changed.
>
> from:  public SerializableTypeOracleBuilder(TreeLogger logger, 
> PropertyOracle propertyOracle, GeneratorContext context) throws 
> UnableToCompleteException
> to:   public SerializableTypeOracleBuilder(TreeLogger logger, 
> GeneratorContext context) throws UnableToCompleteException
>
> There is code in a third-party project, the "gwt20 atmosphere extension" 
> that uses this constructor to create this object. I simply removed the 
> second parameter since it passed in "
>
> context.getPropertyOracle()".
>
>
> But I wonder if this is the correct change. Should this code be calling 
> static method "createSerializableTypeOracleBuilder" instead?
>
> I am unfamiliar with most of this code, so I am unsure how to proceed.
> The code in question is here:
>
>
> https://raw.githubusercontent.com/Atmosphere/atmosphere-extensions/master/gwt20/modules/atmosphere-gwt20-client/src/main/java/org/atmosphere/gwt20/rebind/SerializerGenerator.java
>
> on line 87/
>
> Kay
>
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/1d0d5662-38e9-46fa-a549-ce542232de2b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to