On Wednesday, October 11, 2017 at 9:02:26 PM UTC+2, Goktug Gokdogan wrote: > > There should be something around syncToServer + HtmlUnit causes the issue > (I guess RPC gets called back sooner than timeout(0) but didn't debug) but > I don't think this in practice will effect anything else. > > Enabling batch mode by default for everything potentially effects timeouts > also sometimes it might be incompatible with the test runner that drives > the java side of the tests (for example it doesn't work well with our > internal test sharding mechanism). Hence I don't think it worths the > trouble. I think just having batch mode enabled for junit tests is good > enough to move forward. >
(Assuming you mean the c.g.g.junit tests here) we only have one big target (with many variants) in user/build.xml that runs all the tests. I added "-batch module" to all the HtmlUnit (non-devmode) variants. > Daniel's patch is important for both hand written jsinterop code and > Elemental2 and yes unfortunately Scheduler.scheduleFinally will be affected. > Thanks for the confirmation, and above details. > PS: pls avoid the urge to discuss technical stuff in steering commitee and > try to keep it in the contributor list ;) > +1 It just happens that we were having this meeting and were discussing 2.8.2. Daniel confirmed that it should only affect HtmlUnit, and pushed for its inclusion in 2.8.2. We thus decided to give it a try. But I still did expect written answers in this thread :) Also, I sent the patch just before shutting down my PC for the evening and getting home (hey, UTC+2 here ;-) ), hoping that they could get merged over night and have the tests exercised; except, well, I forgot that the HtmlUnit workaround patch had checkstyle issues… -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/8fa15636-3f1d-455f-988f-706f8614d1e6%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
