>> This is what everyone says you should do and you refuse to because… reasons. I have never disagreed to that, see https://github.com/gwtproject/gwt/issues/9693#issuecomment-816517718 I even have considered adopting such an approach, like Lofi's, in future projects. What I am against is being pushed to move away from use of "Embedded Jetty".
>> Can you stop talking about "classpath misalignment"? I already explained there's no issue with what GWT currently does wrt ASM. Fine, I am happy to call this whatever you please. I have produced a workaround which will keep working as long as EmbeddedJetty doesn't get retired. However, a part of me would still prefer seeing GWT being built with a more recent version of Jetty and ideally same ASM etc. to enforce use of same API baselines. Your call. >> This is a classpath management issue that's unrelated to GWT Fine, I am happy to call this whatever you please. The workaround will keep satisfying my needs as long as EmbeddedJetty doesn't get retired. However, a part of me would still prefer seeing GWT being built with a more recent version of Jetty and ideally same ASM etc. to enforce use of same API baselines. Your call. Long story short, don't remove EmbeddedJetty support from DevMode and please stop pushing people to move away from "Embedded Jetty" if they don't want to for their own reasons. On Tuesday, 4 May 2021 at 16:54:45 UTC+1 t.br...@gmail.com wrote: > On Tue, May 4, 2021 at 10:20 AM eliasb...@gmail.com <eliasb...@gmail.com> > wrote: > >> My 2 cents, >> >> I understand very well where "Lofi" is coming from. >> >> He tries to simplify the GWT server-side by moving all the potentially >> conflicting classpath dependencies to a separate application. >> > > Er, no. > He cleanly separates the server classpath from GWT's classpath, because > there's absolutely zero reason you would put your server-side dependencies > in the classpath for building your client-side code (you'll never use a > Spring class from your GWT client code, so why put Spring in the > classpath?). All this does is make GWT slower (because it scans the entire > classpath, so the bigger it is, the slower the scanning) and create > conflicts (exactly what you've experienced) > This is what everyone says you should do and you refuse to because… > reasons. > (note that it doesn't even mean that you cannot serve your webapp from > DevMode, as the webapp should get its classes from WEB-INF/lib) > > >> This recipe indeed involves an extra step but it doesn't change at all >> the situation with "DevMode+Jetty" and the associated classpath >> misalignment, particularly with GWT 2.9+ while the >> "DevMode+Jetty+CodeServer" combination still runs in a single step. >> Therefore, I still vote in favor of keeping DevMode, removing support for >> Java7, upgrading Jety to more recent version and use of same transitive >> dependencies between GWT and Jetty (e.g. ASM). >> > > Can you stop talking about "classpath misalignment"? I already explained > there's no issue with what GWT currently does wrt ASM. > > >> FYI, if it helps anyone, I have found a workaround to the classpath >> misalignment issue (see >> https://github.com/gwtproject/gwt/issues/9693#issuecomment-822016533) >> which works both for GWT2.9+ and previous versions. >> > > Here you're fixing a Maven dependency "mediation" issue where Maven picks > a version of ASM that's not compatible with GWT. This is a classpath > management issue that's unrelated to GWT (had you used Gradle for instance, > it would have been different, because it would have picked the highest ASM > version), and of course this is because you put your server-side > dependencies in GWT's classpath (with a very convoluted setup; > https://xkcd.com/1172/). > > -- > Thomas Broyer > /tɔ.ma.bʁwa.je/ <http://xn--nna.ma.xn--bwa-xxb.je/> > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/c72dd752-4fff-41d8-ab18-3fc473d56e2fn%40googlegroups.com.
