http://bugs.gpodder.org/show_bug.cgi?id=24
Thomas Perl <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED AssignedTo|[email protected] |[email protected] --- Comment #9 from Thomas Perl <[email protected]> 2009-03-10 13:11:28 --- (In reply to comment #8) > Created an attachment (id=261) --> (http://bugs.gpodder.org/attachment.cgi?id=261) [details] > get length metadata when fedd says lenght=0 Marco, thanks for your patch. Some comments / suggestions / feedback: The filesize should be saved in the SQLite database, in order to avoid downloading file sizes more often - I suspect the current patch does not do this? Have a look into src/gpodder/dbsqlite.py. Apart from that, your patch looks good so far. Maybe also add an option in order to disable this behaviour (see src/gpodder/config.py where you can add a boolean config variable that you can then use in an if by simply saying "if gl.config.variablename:"). When the feature is disabled, the behaviour should be the current one (simply ignore the length by setting it to -1. Feel free to ask if you need any more help there :) -- Configure bugmail: http://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
