Hello,
I found this bug that's been bugging me for a couple of days in the
libipodsync code. If you have a channel with more than one new episode and
try to sync the channel it will only copy the older one first. Then you sync
again and it'll copy the second oldest one. That keeps going till there are
no new episodes.
The attached one-liner patch fixes that and I don't think it disturbs anything
else. The function the if statement is testing should always be returning
True, but for some odd reason the function was returning None. When it synced
an episode that 'None' stopping the the rest of that channel from being
synced.
I hope I didn't miss anything, I'm tired and have a headache :(
g'night,
nick
--- libipodsync.py 2007-08-08 22:08:09.000000000 -0400
+++ libipodsync.py 2007-08-08 22:06:10.000000000 -0400
@@ -162,8 +162,7 @@
return False
self.set_progress( pos, max)
if channel.is_downloaded( episode) and channel.get_file_type( episode) in ( 'audio', 'video' ) and (sync_played_episodes or not channel.is_played( episode)):
- if not self.add_episode_from_channel( channel, episode):
- return False
+ self.add_episode_from_channel( channel, episode)
pos = pos + 1
self.set_progress( pos, max)
_______________________________________________
gpodder-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-devel
