Hi Jérôme, I found a little bug in your new patch. This happens when I cancel a download: http://img151.imageshack.us/img151/4465/gpodderwj0.jpg (look in the bottom right corner)
Pieter On Dec 23, 2007 4:11 PM, Jérôme Chabod <[EMAIL PROTECTED]> wrote: > Hello, > I send you a new patch (for revison 503): > > * I moved the class GPodderStatusIcon in it´s own file (it's easier to > maintain) > * it uses python-notify instead of dbus > * during download, the status icon shows a small arrow > * during download tooltip and notification also list successfully > dowloaded files (idea from Pieter De Decker) > * notification and icon for feed update > > Thank you for you comments. See mine bellow: > > Pieter De Decker a écrit : > > I have two of things to say about the notifications: > - Try to make them a little more descriptive. I'm sure that you've already > thought of that and that you're working on it, but there's more. What if a > certain episode is called "My super duper special podcast episode with a > special guest host for December 21st 2007"? You could solve this by limiting > the episode name to the first 25 (or so) characters, followed by "(...)". > Example: "'My super duper special po(...)' has been downloaded > successfully". > > You'll probably like this version. I don't notify every file download > because it's very annoying having to much popup windows, but the tooltip > displays during dowload already dowloaded files, and the notify also lists > them > > > nikosapi a écrit : > > Attached is a very basic autoupdate addition to your patch. What it does, is > every 20min it runs update_feed_cache. This behaviour is controlled by a > configuration option in the Preferences window. > > > It sound good, but I was unfortunately unable to apply the patch . I just > integrated manualy the thinks you modifed in GPodderStatusIcon. Can > somebody, merge it with my attached patch? > Shouldn't also the 20min delay be configurable in the preference window? > > Paul Rudkin a écrit : > > I love this, thanks for the time and effort you put into creating this patch. > > > Thanks for trying it, Thanks to all developpers, Thomas first, for > gPodder. > > Thomas Perl a écrit : > > * You could use python-notify instead of directly accessing d-bus > > For the python-notify (pynotify) usage: I think you can then use the > "set_timeout()" function on a Notification object to add the "coutdown > timer" to the notification windows, as Pieter De Decker suggested in his > mail. > > The "countdown timer" actually appears when you add an action (a button > within the bubble). > I add actions, unfortunately It doesn't work, so I commented them. The > buttons appears, but my callback function is not called. It certainly due to > my poor experience in python but I can't figure out why. Could you (or > somebody else) have a look at my code. See the commented lines > "send_notification" and "__action_callback" methods of the GPodderStatusIcon > class > > get_tree_icon() from gpodder.util could be helpful here. This is the > function that is used to add the bullet or padlock to the icons in the > episode list. You could extend this function and be able to get the > gPodder icon with some "downloading" (e.g. arrow down) or checking (e.g. > the "refresh" icon) in the lower right-hand corner of the icon. > > > I used you code as inspiration but I had my own method for more > flexibility (I use a dictionary, it's quite easy to add as status) > > * error handling: what to do in case of error? > - critical errors where the use can't help (bug, missing dependency...). > - troubleshouting where the user might do something (server down, xml > invalid, disk full, ...). > > > Basically, the user is already notified about errors. What needs to be > done is to redirect the show_notification() (and probably also > show_confirmation()?) calls to the tray icon (and therefore libnotify) > if the gPodder window has been hidden and only the tray icon is visible.m > > I´ll check this > > > > > > > > _______________________________________________ > gpodder-devel mailing list > [email protected] > https://lists.berlios.de/mailman/listinfo/gpodder-devel > >
_______________________________________________ gpodder-devel mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-devel
