Re: [gpodder-devel] New tray features not in newest gpodder trunk.

Sat, 02 Feb 2008 16:03:59 -0800

Hello Shane,
I can not reproduce this bug. On my computer, when gpodder is minimized, no popups appears when no new episode was found, and only notification for other cases.
You say the last rev. with the feature was ok was 550. Indeed, Thomas made a modification on the tray icon beheviour when minimized on the next revision which can be the reason:
----------------------------------------------------------------------
 svn diff -c551
...
     def show_message( self, message, title = None):
--        if self.tray_icon and self.minimized:
+        if hasattr(self, 'tray_icon') and hasattr(self, 'minimized') and self.tray_icon and self.minimized:
 ...
----------------------------------------------------------------
But I can't understand why it brake you gpodder. Maybe Thomas can help here.

Can you please try to apply the patch in attachement which reverts Thomas modification and tell us if it's work?

Thanks
Jérôme


Shane Donohoe a écrit : 
The newest revision (556) also doesn't seem to have the features
performing correctly. When gpodder is minimized and the tray icon is
enabled, it still pops up windows every now and again saying there are
no new episodes to download, which is very annoying. I think the last
revision to perform this functionality properly was 550.


On Mon, 2008-01-28 at 12:02 +0100, Thomas Perl wrote:

  
Hello, Shane!

On Sun, 2008-01-27 at 16:15 +0000, Shane Donohoe wrote:
    
I got the newest trunk of gpodder, which is rev 551. I noticed the newly
introduced features of having notifications instead of pop up windows
when the main window is minimized have gone. gpodder now pops up windows
saying there are no new episodes as well as when a feed could not be
read.
      
You must have the tray icon enabled when doing this - have you done
that?

Thomas
    

_______________________________________________
gpodder-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-devel


  

Index: src/gpodder/gui.py
===================================================================
--- src/gpodder/gui.py	(révision 556)
+++ src/gpodder/gui.py	(copie de travail)
@@ -95,7 +95,7 @@
         util.idle_add(self.show_message, message, title)
 
     def show_message( self, message, title = None):
-        if hasattr(self, 'tray_icon') and hasattr(self, 'minimized') and self.tray_icon and self.minimized:
+        if self.tray_icon and self.minimized:
             if title is None:
                 title = 'gPodder'
             self.tray_icon.send_notification(message, title, [self.tray_icon.ACTION_SHOW])            

_______________________________________________
gpodder-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-devel

Reply via email to