Yes, it is :) In short - no one has eliminated old tcl/tk versions out there. Any patch needs to work with old and new approach too. Also forms isn't the only place where interp result is used (lazy to grep)
Maris. 2009/1/21 Markus Neteler <nete...@osgeo.org>: > On Tue, Jan 20, 2009 at 11:20 AM, Maris Nartiss <maris....@gmail.com> wrote: >> Hello, >> there was similar issue reported on Mac. It comes from tcl.h where >> they recommend not to use result: >> 463 typedef struct Tcl_Interp { >> 464 /* TIP #330: Strongly discourage extensions from using the >> string result. */ >> 465 #ifdef USE_INTERP_RESULT > > Good hint! > > They propose to use Tcl_GetObjResult(): > http://wiki.tcl.tk/21120 > > Is the following patch nonsense? > > Index: form.c > =================================================================== > --- form.c (revision 35372) > +++ form.c (working copy) > @@ -192,7 +192,7 @@ > TCL_ERROR) { > G_warning > ("Could not set Tcl system encoding to '%s' (%s)", > - Columns[i].value, interp->result); > + Columns[i].value, (char *) Tcl_GetObjResult(interp)); > } > } > continue; > > Wild guessing :) > Markus > _______________________________________________ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev