#1322: DebCheck QA: Possible null pointer dereference
-----------------------------------------------------+----------------------
Reporter: hamish | Owner:
grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 6.4.2
Component: Compiling | Version: 6.4.0
Keywords: lib/nviz, lib/ogsf, r3.stats, v.mapcalc | Platform: Linux
Cpu: Unspecified |
-----------------------------------------------------+----------------------
Hi,
Debian's run of the Cpp check tool automatically found a number of C-code
errors (or potential errors) which need to be reviewed by hand. See grass-
dev ML thread of 13 Jan 2011.
about:
''Cppcheck is a command-line tool that tries to detect bugs that your
C/C++ compiler doesn't see. It is versatile, and can check non-standard
code including various compiler extensions, inline assembly code, etc. Its
internal preprocessor can handle includes, macros, and several
preprocessor commands. While Cppcheck is highly configurable, you can
start using it just by giving it a path to the source code.''
http://www.linuxjournal.com/content/daca-could-mean-less-bugs-debian
the list of probably-bugs in the 6.4.0 C/C++ code:
http://qa.debian.org/daca/cppcheck/squeeze/grass_6.4.0~rc6+42329-3.html
CLI analysis program (not Debian specific):
http://cppcheck.wiki.sourceforge.net
I have split those 154 hits into 16 classes, and will report each class in
an individual bug report.
Run against releasebranch6_4 r42329 (including all patches up to, but not
beyond, 6.4.0-final)
----
This bug report is for: '''Possible null pointer dereference'''
* ./lib/nviz/render.c:122 [error] - Possible null pointer dereference: v
- otherwise it is redundant to check if v is null at line 128
* ./lib/nviz/render.c:123 [error] - Possible null pointer dereference: v
- otherwise it is redundant to check if v is null at line 128
* ./lib/ogsf/gv.c:184 [error] - Possible null pointer dereference: gv -
otherwise it is redundant to check if gv is null at line 186
* ./lib/ogsf/gvl.c:188 [error] - Possible null pointer dereference: gvl -
otherwise it is redundant to check if gvl is null at line 190
* ./raster3d/r3.stats/main.c:665 [error] - Possible null pointer
dereference: eqvals - otherwise it is redundant to check if eqvals is null
at line 672
* ./raster3d/r3.stats/main.c:668 [error] - Possible null pointer
dereference: eqvals - otherwise it is redundant to check if eqvals is null
at line 672
* ./vector/v.mapcalc/list.c:524 [error] - Possible null pointer
dereference: item
* ./vector/v.mapcalc/list.c:525 [error] - Possible null pointer
dereference: item
Modules: lib/nviz, lib/ogsf, r3.stats, v.mapcalc
--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1322>
GRASS GIS <http://grass.osgeo.org>
_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev
