Hi Markus, Unfortunately, the test will have to be more or less rewritten, which is why I for now chose to deactivate it with an info message pointing to the related ticket.
Alternatively, it could be shortened to the one assertModule test that it actually performs on r.basin.fill (see also comments in the ticket). Also skipped tests should remain visible in test reports e.g. on fatra BTW. Cheers Stefan From: grass-dev <grass-dev-boun...@lists.osgeo.org> On Behalf Of Markus Neteler Sent: onsdag 24. april 2019 22:45 To: GRASS developers list <grass-dev@lists.osgeo.org> Subject: Re: [GRASS-dev] [GRASS-SVN] r74423 - grass/trunk/raster/r.basins.fill/testsuite Hi Stefan, <svn_gr...@osgeo.org<mailto:svn_gr...@osgeo.org>> schrieb am Mi., 24. Apr. 2019, 22:41: Author: sbl Date: 2019-04-24 13:41:37 -0700 (Wed, 24 Apr 2019) New Revision: 74423 Modified: grass/trunk/raster/r.basins.fill/testsuite/testrbf.py Log: deactivate erroneous test; see #3822 Modified: grass/trunk/raster/r.basins.fill/testsuite/testrbf.py =================================================================== --- grass/trunk/raster/r.basins.fill/testsuite/testrbf.py 2019-04-24 20:33:36 UTC (rev 74422) +++ grass/trunk/raster/r.basins.fill/testsuite/testrbf.py 2019-04-24 20:41:37 UTC (rev 74423) @@ -8,8 +8,10 @@ License (>=v2). Read the file COPYING that comes with GRASS for details. """ +import unittest from grass.gunittest.case import TestCase +@unittest.skip("See<mailto:+@unittest.skip(%22See> #3822") class TestRasterbasin(TestCase): celevation='elevation' tgeology='geology' Did you see the attachment? I'd prefer to fix the test rather than skip it (and forget)... Markus
_______________________________________________ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
