bgarrigues pushed a commit to branch automake3
in repository groff.
commit 128cb4dbc6a860d43560fe9f51c9f8507f18d51c
Author: Ingo Schwarze <[email protected]>
Date: Tue Sep 9 23:18:22 2014 +0200
correct usage of the test utility
According to POSIX, when called with one argument, test(1) shall
behave as follows: Exit true (0) if $1 is not null; otherwise, exit
false.
Consequently, this behaviour is correct:
$ test -n
$ echo $?
0
$ test -n ""
$ echo $?
1
---
configure.ac | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/configure.ac b/configure.ac
index 3428e69..86aec06 100644
--- a/configure.ac
+++ b/configure.ac
@@ -182,14 +182,14 @@ gl_LOCALCHARSET
# src/libs/libxutil
AM_CONDITIONAL([WITHOUT_X11], [test "x$groff_no_x" = "xyes"])
-AM_CONDITIONAL([BUILD_INFODOC], [test -n $make_infodoc])
-AM_CONDITIONAL([BUILD_HTML], [test -n $make_htmldoc])
-AM_CONDITIONAL([BUILD_HTMLEXAMPLES], [test -n $make_htmlexamples])
-AM_CONDITIONAL([BUILD_PDFDOC], [test -n $make_pdfdoc])
-AM_CONDITIONAL([BUILD_PDFEXAMPLES], [test -n $make_pdfexamples])
-AM_CONDITIONAL([BUILD_OTHERDOC], [test -n $make_otherdoc])
-AM_CONDITIONAL([BUILD_EXAMPLES], [test -n $make_examples])
-AM_CONDITIONAL([INSTALL_SHIPPED_HTML], [test -n $make_install_shipped_htmldoc])
+AM_CONDITIONAL([BUILD_INFODOC], [test -n "$make_infodoc"])
+AM_CONDITIONAL([BUILD_HTML], [test -n "$make_htmldoc"])
+AM_CONDITIONAL([BUILD_HTMLEXAMPLES], [test -n "$make_htmlexamples"])
+AM_CONDITIONAL([BUILD_PDFDOC], [test -n "$make_pdfdoc"])
+AM_CONDITIONAL([BUILD_PDFEXAMPLES], [test -n "$make_pdfexamples"])
+AM_CONDITIONAL([BUILD_OTHERDOC], [test -n "$make_otherdoc"])
+AM_CONDITIONAL([BUILD_EXAMPLES], [test -n "$make_examples"])
+AM_CONDITIONAL([INSTALL_SHIPPED_HTML], [test -n
"$make_install_shipped_htmldoc"])
AC_CONFIG_FILES([Makefile])
AC_OUTPUT
_______________________________________________
Groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
