gbranden pushed a commit to branch master
in repository groff.
commit 4366a2dacf150387f9a510b3581a71015f592430
Author: G. Branden Robinson <[email protected]>
AuthorDate: Fri Dec 29 13:22:47 2023 -0600
[troff]: Plant assertion bomb in stub function.
* src/roff/troff/input.cpp (charinfo::contains): Add sure-to-fail
`assert()` to member function taking a `charinfo` pointer and a
`bool`. It has been marked "TODO" and unconditionally returning false
for 13 years. We should find out if it blows up in real-world use.
---
ChangeLog | 8 ++++++++
src/roff/troff/input.cpp | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 5261ec83a..859f8d1b7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2023-12-29 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/input.cpp (charinfo::contains): Add
+ sure-to-fail `assert()` to member function taking a `charinfo`
+ pointer and a `bool`. It has been marked "TODO" and
+ unconditionally returning false for 13 years. We should find
+ out if it blows up in real-world use.
+
2023-12-29 G. Branden Robinson <[email protected]>
* src/preproc/tbl/table.cpp (table::add_entry): Recast
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 27ed9d57a..214349bd9 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -9341,7 +9341,8 @@ bool charinfo::contains(symbol s, bool already_called)
bool charinfo::contains(charinfo *, bool)
{
- // TODO
+ // Werner Lemberg marked this as "TODO" in 2010.
+ assert(0 == "unimplemented member function");
return false;
}
_______________________________________________
Groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
