gbranden pushed a commit to branch master
in repository groff.
commit 8c557db00ba1733b092807f16d0be988337d136b
Author: Alejandro Colomar <a...@kernel.org>
AuthorDate: Sat Mar 16 13:34:48 2024 +0100
[grolbp]: Remove bogus (and redundant) check.
* src/devices/grolbp/lbp.cpp (main): Remove bogus (and redundant) check.
`str == end` can only happen if strtol(3) returns 0.
Fixes: 98608a8ba037 ("grolbp output device")
Link: <https://savannah.gnu.org/bugs/?65451>
Cc: "G. Branden Robinson" <bran...@debian.org>
Cc: Dave Kemper <saint.s...@gmail.com>
Cc: "James K. Lowden" <jklow...@schemamania.org>
Cc: Colin Watson <cjwat...@debian.org>
Cc: Werner LEMBERG <w...@gnu.org>
Cc: James Clark <j...@jclark.com>
Signed-off-by: Alejandro Colomar <a...@kernel.org>
---
ChangeLog | 6 ++++++
src/devices/grolbp/lbp.cpp | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index f2d532a87..395816d31 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-03-16 Alejandro Colomar <a...@kernel.org>
+
+ * src/devices/grolbp/lbp.cpp (main): Remove bogus (and
+ redundant) check. `str == end` can only happen if strtol(3)
+ returns 0.
+
2024-03-16 Alejandro Colomar <a...@kernel.org>
* src/devices/grodvi/dvi.cpp
diff --git a/src/devices/grolbp/lbp.cpp b/src/devices/grolbp/lbp.cpp
index 63077f16e..c05b42ec3 100644
--- a/src/devices/grolbp/lbp.cpp
+++ b/src/devices/grolbp/lbp.cpp
@@ -696,7 +696,7 @@ int main(int argc, char **argv)
{
char *ptr;
long n = strtol(optarg, &ptr, 10);
- if ((n <= 0) && (ptr == optarg))
+ if (ptr == optarg)
error("argument for -c must be a positive integer");
else if (n <= 0 || n > 32767)
error("out of range argument for -c");
_______________________________________________
Groff-commit mailing list
Groff-commit@gnu.org
https://lists.gnu.org/mailman/listinfo/groff-commit
