gbranden pushed a commit to branch master
in repository groff.

commit cfc70a21c40d4b1685647fcb3dc3e9ab6ba7685b
Author: G. Branden Robinson <[email protected]>
AuthorDate: Sun Apr 13 09:23:09 2025 -0500

    [troff]: Null-terminate `grosteam`'s `mode`.
    
    * src/roff/troff/input.cpp (grostream::grostream): Null-terminate `mode`
      structure member as well.
---
 ChangeLog                | 5 +++++
 src/roff/troff/input.cpp | 4 +++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index e985f4244..1af1f746b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2025-04-13  G. Branden Robinson <[email protected]>
+
+       * src/roff/troff/input.cpp (grostream::grostream):
+       Null-terminate `mode` structure member as well.
+
 2025-04-12  G. Branden Robinson <[email protected]>
 
        * src/roff/troff/input.cpp (do_write_request): Fix SEGV when
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 019de8783..b97e2cf5e 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -7616,7 +7616,9 @@ struct grostream {
 grostream::grostream(const string &fn, string m, FILE *fp)
 : filename(fn), mode(m), file(fp)
 {
-  filename += '\0'; // Don't leak garbage in print_streams().
+  // Don't leak garbage in print_streams().
+  filename += '\0';
+  mode += '\0';
 }
 
 // XXX: Maybe we should try to close the libc FILE stream here.

_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit

Reply via email to