gbranden pushed a commit to branch master
in repository groff.
commit 0c7010230ee4d35acb7927174d90b9de076cd4d5
Author: G. Branden Robinson <[email protected]>
AuthorDate: Mon Apr 21 12:58:26 2025 -0500
[troff]: Fix build failure with Clang 20.
* src/roff/troff/node.cpp (is_valid_font_mounting_position): Drop
`inline` from definition of externally visible function. "[T]he ...
otherwise perfectly logical combination of external linkage and
inlining is banned to make life simpler for compiler writers[.]."
(_The C++ Programming Language, Special Edition_, Stroustrup, 1997, p.
199).
---
ChangeLog | 11 +++++++++++
src/roff/troff/node.cpp | 2 +-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index fb57a8269..51f3fa921 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2025-04-21 G. Branden Robinson <[email protected]>
+
+ [troff]: Fix build failure with Clang 20.
+
+ * src/roff/troff/node.cpp (is_valid_font_mounting_position):
+ Drop `inline` from definition of externally visible function.
+ "[T]he ... otherwise perfectly logical combination of external
+ linkage and inlining is banned to make life simpler for compiler
+ writers[.]." (_The C++ Programming Language, Special Edition_,
+ Stroustrup, 1997, p. 199).
+
2025-04-21 G. Branden Robinson <[email protected]>
* src/roff/troff/node.cpp (env_font_emboldening_offset)
diff --git a/src/roff/troff/node.cpp b/src/roff/troff/node.cpp
index 9f6053733..18fd33152 100644
--- a/src/roff/troff/node.cpp
+++ b/src/roff/troff/node.cpp
@@ -6723,7 +6723,7 @@ static void font_lookup_error(font_lookup_info& finfo,
finfo.requested_position, msg);
}
-inline bool is_valid_font_mounting_position(int n)
+bool is_valid_font_mounting_position(int n)
{
return (n >= 0)
&& (n < font_table_size)
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
