gbranden pushed a commit to branch master
in repository groff.
commit c7ac9de630c9ffdc9ed86e23b335db996bd472bd
Author: G. Branden Robinson <[email protected]>
AuthorDate: Fri May 16 04:11:59 2025 -0500
src/roff/troff/input.cpp: Un-pessimize function.
* src/roff/troff/input.cpp (open_file): Un-pessimize. Stop senselessly
recomputing string literal selection when we already have a `char`
pointer we can use.
---
ChangeLog | 6 ++++++
src/roff/troff/input.cpp | 3 +--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 22cf81949..e7e017684 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2025-05-16 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/input.cpp (open_file): Un-pessimize. Stop
+ senselessly recomputing string literal selection when we already
+ have a `char` pointer we can use.
+
2025-05-16 G. Branden Robinson <[email protected]>
* src/roff/troff/input.cpp (print_streams): Mark as `static`
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 4a1866ed6..31eadaf93 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -7678,8 +7678,7 @@ static void open_file(bool appending)
errno = 0;
FILE *fp = fopen(filename, appending ? "a" : "w");
if (0 /* nullptr */ == fp) {
- error("cannot open file '%1' for %2: %3", filename,
- appending ? "appending" : "writing",
+ error("cannot open file '%1' for %2: %3", filename, mode,
strerror(errno));
// If we already had a key of this name in the dictionary, it's
// invalid now.
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
