gbranden pushed a commit to branch master
in repository groff.
commit 3fb9b61c53988824a1eb9367b40ea0ae3abbe95d
Author: G. Branden Robinson <[email protected]>
AuthorDate: Thu May 15 16:44:49 2025 -0500
[troff]: Continue fixing Savanah #64104.
...after two years.
* src/roff/troff/input.cpp (assign_control_character): Fix bug when `cc`
request given no arguments; don't try to make the control character
`\` (which fails unless the user has already changed the escape
character). Make it `.` instead, as documented.
(assign_no_break_control_character): Fix bug when `c2` request given
no arguments; don't try to make the no-break control character `\`
(which fails unless the user has already changed the escape
character). Make it `'` instead, as documented.
Continues fixing <https://savannah.gnu.org/bugs/?64104>. Problem
introduced by me in a branch on 7 March 2023, but not merged onto the
trunk until 10 July of that year, after the groff 1.23.0 release
(fortunately).
---
ChangeLog | 19 +++++++++++++++++++
src/roff/troff/input.cpp | 4 ++--
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 5360dfb1b..703abc402 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,22 @@
+2025-05-15 G. Branden Robinson <[email protected]>
+
+ [troff]: Continue fixing Savanah #64104 after two years.
+
+ * src/roff/troff/input.cpp (assign_control_character): Fix bug
+ when `cc` request given no arguments; don't try to make the
+ control character `\` (which fails unless the user has already
+ changed the escape character). Make it `.` instead, as
+ documented.
+ (assign_no_break_control_character): Fix bug when `c2` request
+ given no arguments; don't try to make the no-break control
+ character `\` (which fails unless the user has already changed
+ the escape character). Make it `'` instead, as documented.
+
+ Continues fixing <https://savannah.gnu.org/bugs/?64104>.
+ Problem introduced by me in a branch on 7 March 2023, but not
+ merged onto the trunk until 10 July of that year, after the
+ groff 1.23.0 release (fortunately).
+
2025-05-15 G. Branden Robinson <[email protected]>
src/roff/troff/input.cpp: Fix code style nit.
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 2eccad4e1..e32d26552 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -257,7 +257,7 @@ void assign_control_character()
cc = tok.ch();
}
else
- cc = '\\';
+ cc = '.';
bool do_nothing = false;
char already_ec[] = "the escape character is already";
char already_nbcc[] = "the no-break control character is already";
@@ -294,7 +294,7 @@ void assign_no_break_control_character()
nbcc = tok.ch();
}
else
- nbcc = '\\';
+ nbcc = '\'';
bool do_nothing = false;
char already_ec[] = "the escape character is already";
char already_cc[] = "the (breaking) control character is already";
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
