gbranden pushed a commit to branch master
in repository groff.
commit 2fc8b75760c75193d9237f78fd6e891aed2aa5ca
Author: G. Branden Robinson <[email protected]>
AuthorDate: Fri May 30 20:23:34 2025 -0500
[troff]: Fix code style nits.
* src/roff/troff/input.cpp (read_title_parts): Fix code style nit;
parenthesize formally complex expressions.
Also break long input lines.
Also annotate null pointers with `nullptr` comment to ease any future
transition to C++11, which defines it as a keyword.
---
ChangeLog | 5 +++++
src/roff/troff/input.cpp | 8 +++++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 321c6110b..a22a2e967 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2025-05-30 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/input.cpp (read_title_parts): Fix code style
+ nit; parenthesize formally complex expressions.
+
2025-05-30 G. Branden Robinson <[email protected]>
[troff]: Trivially refactor, continuing naming reform of
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index fcc45bd6b..57e573416 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -5981,12 +5981,14 @@ void read_title_parts(node **part, hunits *part_width)
tok.next();
for (int i = 0; i < 3; i++) {
while (!tok.is_newline() && !tok.is_eof()) {
- if (tok == start
- && (want_att_compat || input_stack::get_level() == start_level)) {
+ if ((tok == start)
+ && (want_att_compat
+ || input_stack::get_level() == start_level)) {
tok.next();
break;
}
- if (page_character != 0 && tok.get_char() == page_character)
+ if ((page_character != 0 /* nullptr */)
+ && (tok.get_char() == page_character))
interpolate_register(percent_symbol, 0);
else
tok.process();
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
