gbranden pushed a commit to branch master
in repository groff.

commit 6a4c117ee82f072d21e0b2f4e208603a3e67c9b0
Author: G. Branden Robinson <[email protected]>
AuthorDate: Thu Jun 19 10:22:16 2025 -0500

    Revert "[troff]: Add assertions."
    
    This reverts commit af5d597aa2a19784cd378794100b0127998f3a71.
    
    These functions often _do_ get passed null pointers.
---
 ChangeLog               | 6 ------
 src/roff/troff/node.cpp | 2 --
 2 files changed, 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 9b4e9a01d..0dedd2bd0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -738,12 +738,6 @@
        invalid argument encountered when warning of its out-of-range
        status.
 
-2025-05-19  G. Branden Robinson <[email protected]>
-
-       * src/roff/troff/node.cpp (dump_node_list)
-       (dump_node_list_in_reverse): Add assertions.  These functions
-       should never be passed null pointers.
-
 2025-05-19  G. Branden Robinson <[email protected]>
 
        * src/roff/troff/div.cpp (do_divert): Fix code style nit.
diff --git a/src/roff/troff/node.cpp b/src/roff/troff/node.cpp
index f20440146..3b90837c9 100644
--- a/src/roff/troff/node.cpp
+++ b/src/roff/troff/node.cpp
@@ -2546,7 +2546,6 @@ void delete_node_list(node *n)
 
 void dump_node_list(node *n)
 {
-  assert(n != 0 /* nullptr */);
   bool need_comma = false;
   fputc('[', stderr);
   while (n != 0 /* nullptr */) {
@@ -2799,7 +2798,6 @@ void container_node::dump_node()
 
 void dump_node_list_in_reverse(node *nlist)
 {
-  assert(nlist != 0 /* nullptr */);
   // It's stored in reverse order already; this puts it forward again.
   std::stack<node *> reversed_node_list;
   node *n = nlist;

_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit

Reply via email to