gbranden pushed a commit to branch master
in repository groff.
commit ebe570d9ef4013fc3f8dfaca6e61911f0615a258
Author: G. Branden Robinson <[email protected]>
AuthorDate: Sat Aug 2 18:37:31 2025 -0500
[grog]: Trivially refactor to fix a Perl warning.
* src/utils/grog/grog.pl (warn): Rename this subroutine...
(gripe): ...to this.
(infer_man_or_ms_package, construct_command): Update call sites.
Fixes:
Ambiguous call resolved as CORE::warn(), qualify as such or use & at ...
---
ChangeLog | 8 ++++++++
src/utils/grog/grog.pl | 8 ++++----
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 54dd33535..b3ca939da 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2025-08-02 G. Branden Robinson <[email protected]>
+
+ * src/utils/grog/grog.pl: Trivially refactor to fix a Perl
+ warning.
+ (warn): Rename this subroutine...
+ (gripe): ...to this.
+ (infer_man_or_ms_package, construct_command): Update call sites.
+
2025-08-02 G. Branden Robinson <[email protected]>
* src/utils/grog/grog.pl: Fix code style nit. Stop using `&`
diff --git a/src/utils/grog/grog.pl b/src/utils/grog/grog.pl
index 7c5b5233f..ca1fefe1b 100644
--- a/src/utils/grog/grog.pl
+++ b/src/utils/grog/grog.pl
@@ -76,7 +76,7 @@ sub fail {
}
-sub warn {
+sub gripe {
my $text = shift;
print STDERR "$program_name: warning: $text\n";
}
@@ -554,7 +554,7 @@ sub infer_man_or_ms_package {
if (!$score{'TH'}) {
push_main_package('s');
} else {
- warn("document ambiguous; disambiguate with -man or -ms option");
+ gripe("document ambiguous; disambiguate with -man or -ms option");
$had_inference_problem = 1;
}
return 0;
@@ -620,7 +620,7 @@ sub construct_command {
for my $pkg (@main_package) {
if (grep(/$pkg/, @inferred_main_package)) {
$main_package = $pkg;
- warn("document ambiguous (choosing '$main_package'"
+ gripe("document ambiguous (choosing '$main_package'"
. " from '@inferred_main_package'); disambiguate with -m"
. " option");
$had_inference_problem = 1;
@@ -639,7 +639,7 @@ sub construct_command {
if (grep(/$pkg/, @main_package)) {
$is_auxiliary_package = 0;
if ($main_package && ($pkg ne $main_package)) {
- warn("overriding inferred package '$main_package'"
+ gripe("overriding inferred package '$main_package'"
. " with requested package '$pkg'");
}
$main_package = $pkg;
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
