gbranden pushed a commit to branch master
in repository groff.
commit e074c55f2794ff7e8c49a3a103383dd3fde73849
Author: G. Branden Robinson <[email protected]>
AuthorDate: Wed Nov 26 00:18:49 2025 -0600
[troff]: Fix code style nit.
* src/roff/troff/input.cpp (do_get_long_name, read_size):
* src/roff/troff/reg.cpp (assign_register_format_request): Parenthesize
formally complex expressions.
---
ChangeLog | 6 ++++++
src/roff/troff/input.cpp | 8 ++++----
src/roff/troff/reg.cpp | 5 ++++-
3 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index b96e25100..03bbda100 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2025-11-26 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/input.cpp (do_get_long_name, read_size):
+ * src/roff/troff/reg.cpp (assign_register_format_request): Fix
+ code style nit; parenthesize formally complex expressions.
+
2025-11-25 G. Branden Robinson <[email protected]>
* src/roff/troff/input.cpp (do_name_test, return_macro_request):
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index d4652c329..ef1db1d60 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -3158,7 +3158,7 @@ static symbol do_get_long_name(bool required, char
end_char)
buf_size = new_buf_size;
delete[] old_buf;
}
- if ((buf[i] = tok.ch()) == 0U || (buf[i] == end_char))
+ if (((buf[i] = tok.ch()) == 0U) || (buf[i] == end_char))
break;
i++;
tok.next();
@@ -6097,13 +6097,13 @@ static bool read_size(int *x) // \s
token start(tok);
tok.next();
c = tok.ch();
- if (!inc && (c == '-' || c == '+')) {
- inc = c == '+' ? 1 : -1;
+ if (!inc && ((c == '-') || (c == '+'))) {
+ inc = (c == '+') ? 1 : -1;
tok.next();
}
if (!read_measurement(&val, 'z'))
return false;
- if (!(start.ch() == '[' && tok.ch() == ']') && start != tok) {
+ if (!((start.ch() == '[') && (tok.ch() == ']')) && (start != tok)) {
if (start.ch() == '[')
error("missing ']' in type size escape sequence");
else
diff --git a/src/roff/troff/reg.cpp b/src/roff/troff/reg.cpp
index 1314ba23e..c1ae3a371 100644
--- a/src/roff/troff/reg.cpp
+++ b/src/roff/troff/reg.cpp
@@ -456,7 +456,10 @@ static void assign_register_format_request()
} while (csdigit(tok.ch()));
r->alter_format('1', n);
}
- else if (c == 'i' || c == 'I' || c == 'a' || c == 'A')
+ else if ((c == 'i')
+ || (c == 'I')
+ || (c == 'a')
+ || (c == 'A'))
r->alter_format(c);
else if (!has_arg())
warning(WARN_MISSING, "register interpolation format assignment"
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
