gbranden pushed a commit to branch master
in repository groff.
commit 149c18a3d49ee93eeab429748a1867d9ac6ea66c
Author: G. Branden Robinson <[email protected]>
AuthorDate: Mon Dec 1 20:39:18 2025 -0600
[gxditview]: Fix Savannah #67754.
* src/devices/xditview/xditview.am
(src/devices/xditview/GXditview-ad.h): Add `$(MKDIR_P)` to target rule
to ensure the parent directory exists. This problem is hard to
observe because it shows up only when our `configure` script is run
with the `--disable-dependency-tracking` option and, apparently,
stochastically with highly parallelized builds. {A "stock" build
never encounters it because with "dependency tracking", Automake
generates make(1) files that create ".deps" files in the build tree,
and a prerequisite to doing so is to create the parents of the
directories housing them, a convenience that this target rule snuck
through.}
Fixes <https://savannah.gnu.org/bugs/?67754> and
<https://bugs.debian.org/1121570>. Problem dates back at least to
commit 62a22cb540, 22 August 2014 (but which did not appear in the
"master" branch until 27 January of the next year), when groff's build
system adopted Automake. Thanks to Helmut Grohne for the report and
Colin Watson for assistance reproducing it.
ANNOUNCE: Acknowledge Helmut.
---
ANNOUNCE | 1 +
ChangeLog | 21 +++++++++++++++++++++
src/devices/xditview/xditview.am | 1 +
3 files changed, 23 insertions(+)
diff --git a/ANNOUNCE b/ANNOUNCE
index 3f877984d..75dfcbb81 100644
--- a/ANNOUNCE
+++ b/ANNOUNCE
@@ -185,6 +185,7 @@ Hanno Boeck
Hans Bezemer
Heinz-Jürgen Oertel
Helge Kreutzmann
+Helmut Grohne
Ian Ropers
Ingo Schwarze
James Cloos
diff --git a/ChangeLog b/ChangeLog
index 542134e94..85deda44e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,24 @@
+2025-12-01 G. Branden Robinson <[email protected]>
+
+ * src/devices/xditview/xditview.am
+ (src/devices/xditview/GXditview-ad.h): Add `$(MKDIR_P)` to
+ target rule to ensure the parent directory exists. This problem
+ is hard to observe because it shows up only when our `configure`
+ script is run with the `--disable-dependency-tracking` option
+ and, apparently, stochastically with highly parallelized builds.
+ {A "stock" build never encounters it because with
+ "dependency tracking", Automake generates make(1) files that
+ create ".deps" files in the build tree, and a prerequisite to
+ doing so is to create the parents of the directories housing
+ them, a convenience that this target rule snuck through.}
+
+ Fixes <https://savannah.gnu.org/bugs/?67754> and
+ <https://bugs.debian.org/1121570>. Problem dates back at least
+ to commit 62a22cb540, 22 August 2014 (but which did not appear
+ in the "master" branch until 27 January of the next year), when
+ groff's build system adopted Automake. Thanks to Helmut Grohne
+ for the report and Colin Watson for assistance reproducing it.
+
2025-12-01 G. Branden Robinson <[email protected]>
* src/roff/troff/input.cpp (charinfo::get_flags): Fix
diff --git a/src/devices/xditview/xditview.am b/src/devices/xditview/xditview.am
index 2f5843c5b..1533298c8 100644
--- a/src/devices/xditview/xditview.am
+++ b/src/devices/xditview/xditview.am
@@ -74,6 +74,7 @@ src/devices/xditview/gxditview-device.$(OBJEXT): defs.h
src/devices/xditview/gxditview-xditview.$(OBJEXT): $(XDITVIEW_GENHDRS)
src/devices/xditview/GXditview-ad.h: $(xditview_srcdir)/GXditview.ad
+ $(AM_V_at)$(MKDIR_P) $(top_builddir)/src/devices/xditview
$(AM_V_GEN)$(SHELL) $(xditview_srcdir)/ad2c \
$(xditview_srcdir)/GXditview.ad > $@
endif
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
