On Thu, Sep 20, 2012, Ivan Shmakov wrote:
> >>>>> Peter Schaffter <pe...@schaffter.ca> writes:
> 
> [...]
> 
>  > groff-current/contrib/mom/Makefile.sub
> 
>  >  PDFMOM=GROFF_COMMAND_PREFIX=''; \
>  >        export GROFF_COMMAND_PREFIX; \
>  > +      GROFF_BIN_PATH=$(GROFF_BIN_PATH); \
>  > +      export GROFF_BIN_PATH; \
>  >        PDFMOM_BIN_PATH=$(top_builddir)/src/devices/gropdf; \
>  >        export PDFMOM_BIN_PATH; \
>  >        $(PDFMOMBIN) $(FFLAG) $(TFLAG)
> 
>       As per the recent POSIX version [1], I'd simplify that down to:
> 
> PDFMOM = \
>       GROFF_COMMAND_PREFIX= \
>       GROFF_BIN_PATH=$(GROFF_BIN_PATH) \
>       PDFMOM_BIN_PATH=$(top_builddir)/src/devices/gropdf \
>       $(PDFMOMBIN) $(FFLAG) $(TFLAG)
> 
>       The same applies to the GROFF variable definition just as well.
> 
> [1] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html

Right. "If a variable is initialized from the environment, it shall
be marked for export immediately..."  I'll clean this up in the CVS
when I do my next commit.

-- 
Peter Schaffter

Author of The Binbrook Caucus
http://www.schaffter.ca

Reply via email to