This bug was fixed in the package openssl - 1.0.2g-1ubuntu4.8

---------------
openssl (1.0.2g-1ubuntu4.8) xenial; urgency=medium

  * aes/asm/aesni-sha*-x86_64.pl: fix IV handling in SHAEXT paths.
    (LP: #1674399)

 -- William Grant <wgr...@ubuntu.com>  Fri, 19 May 2017 18:27:58 +1000

** Changed in: openssl (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1674399

Title:
  OpenSSL CPU detection for AMD Ryzen CPUs

Status in openssl package in Ubuntu:
  Fix Released
Status in openssl source package in Xenial:
  Fix Released
Status in openssl source package in Yakkety:
  Fix Released
Status in openssl source package in Zesty:
  Fix Released
Status in openssl source package in Artful:
  Fix Released

Bug description:
  [Impact]

  * Context:

  AMD added support in their processors for SHA Extensions[1] (CPU flag:
  sha_ni[2]) starting with Ryzen[3] CPU. Note that Ryzen CPU come in
  64bit only (Confirmed with AMD representative). Current OpenSSL
  version in Ryzens still calls SHA for SSSE3 routine as result a number
  of extensions were effectively masked on Ryzen and shows no
  improvement.

  [1] /proc/cpuinfo
  processor : 0
  vendor_id : AuthenticAMD
  cpu family : 23
  model : 1
  model name : AMD Ryzen 5 1600 Six-Core Processor
  flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat 
pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm 
constant_tsc rep_good nopl nonstop_tsc extd_apicid aperfmperf eagerfpu pni 
pclmulqdq monitor ssse3 fma cx16 sse
  4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm 
extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw skinit wdt tce 
topoext perfctr_core perfctr_nb bpext perfctr_l2 mwaitx hw_pstate vmmcall 
fsgsbase bmi1 avx2 smep bmi2 rdseed adx smap clflusho
  pt sha_ni xsaveopt xsavec xgetbv1 clzero arat npt lbrv svm_lock nrip_save 
tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold

  [2] - sha_ni: SHA1/SHA256 Instruction Extensions

  [3] - https://en.wikipedia.org/wiki/Ryzen
  ...
  All models support: x87, MMX, SSE, SSE2, SSE3, SSSE3, SSE4.1, SSE4.2, AES, 
CLMUL, AVX, AVX2, FMA, CVT16/F16C, ABM, BMI1, BMI2, SHA.[5]
  ...

  * Program to performs the CPUID check:

  Reference :
  https://software.intel.com/en-us/articles/intel-sha-extensions

  ... Availability of the Intel® SHA Extensions on a particular
  processor can be determined by checking the SHA CPUID bit in
  CPUID.(EAX=07H, ECX=0):EBX.SHA [bit 29]. The following C function,
  using inline assembly, performs the CPUID check:

  --
  int CheckForIntelShaExtensions() {
     int a, b, c, d;

     // Look for CPUID.7.0.EBX[29]
     // EAX = 7, ECX = 0
     a = 7;
     c = 0;

     asm volatile ("cpuid"
          :"=a"(a), "=b"(b), "=c"(c), "=d"(d)
          :"a"(a), "c"(c)
         );

     // Intel® SHA Extensions feature bit is EBX[29]
     return ((b >> 29) & 1);
  }
  --

  On CPU with sha_ni the program return "1". Otherwise it return "0".

  [Test Case]

   * Reproducible with Xenial/Zesty/Artful release.

   * Generated a checksum of a big file (e.g. 5GB file) with openssl
   $ time /usr/bin/openssl dgst -sha256 /var/tmp/5Gfile
  SHA256(/var/tmp/5Gfile)= 
8d448d81521cbc1bfdc04dd199d448bd3c49374221007bd0846d8d39a70dd4f8

  real  0m12.835s
  user  0m12.344s
  sys   0m0.484s

  * Openssl speed
  $ openssl speed sha1
  Doing sha1 for 3s on 16 size blocks: 9969152 sha1's in 3.00s
  Doing sha1 for 3s on 64 size blocks: 8019164 sha1's in 3.00s
  Doing sha1 for 3s on 256 size blocks: 5254219 sha1's in 2.99s
  Doing sha1 for 3s on 1024 size blocks: 2217067 sha1's in 3.00s
  Doing sha1 for 3s on 8192 size blocks: 347842 sha1's in 3.00s
  OpenSSL 1.0.2g 1 Mar 2016
  built on: reproducible build, date unspecified
  options:bn(64,64) rc4(8x,int) des(idx,cisc,16,int) aes(partial) idea(int) 
blowfish(idx)
  compiler: gcc -I. -I.. -I../include -DOPENSSL_THREADS -D_REENTRANT 
-DDSO_DLFCN -DHAVE_DLFCN_H -Wa,--noexecstack -m64 -DL_ENDIAN -O3 -Wall 
-DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 
-DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DAES_ASM 
-DVPAES_ASM -DBSAES_ASM -DWHIRLPOOL_ASM -DGHASH_ASM -DECP_NISTZ256_ASM
  The 'numbers' are in 1000s of bytes per second processed.
  type 16 bytes 64 bytes 256 bytes 1024 bytes 8192 bytes
  sha1 53168.81k 171075.50k 449859.55k 756758.87k 949840.55

  The performance are clearly better when using the patch which take
  benefit of the sha extension. (See Regression Potential section for
  result with patch)

  [Regression Potential]

   * Note : IRC discussion with infinity :
  
https://bugs.launchpad.net/ubuntu/xenial/+source/openssl/+bug/1674399/comments/8

   * Note from irc discussion with apw and rbasak :
  https://bugs.launchpad.net/ubuntu/+source/openssl/+bug/1674399/comments/2

   * It basically allow openssl to take benefit of sha extension
  potential (mostly performance-wise) now that new AMD cpu starting  to
  have the capability.

  * The code check the CPUID bit to determine if the sha instructions
  are available are not.

  * Maintainer comment proves that he did the successfully tested on
  Intel with/without SHA extension

  Reference: https://github.com/openssl/openssl/issues/2848
  "I don't have access to Ryzen system, so I didn't test it explicitly on 
Ryzen. Reporter did confirm it tough. Myself I tested on Intel processors, yes, 
with/without."

  * LP reporter comment :
  I, slashd, have tested on a Ryzen system (and AMD non-ryzen) and non-sha 
INTEL cpu. It does reveal a significant performance increase on Ryzen due to 
the sha extension :
  (Note that the performance remain the same on non-sha extension CPU 
(AMD/INTEL), as expected since they don't take benefit of the sha extension 
technology)

  [Tested on a Ryzen CPU]
  # Generated a checksum of a big file (e.g. 5GB file) with openssl
   $ time /usr/bin/openssl dgst -sha256 /var/tmp/5Gfile
  SHA256(/var/tmp/5Gfile)= 
8d448d81521cbc1bfdc04dd199d448bd3c49374221007bd0846d8d39a70dd4f8

  real  0m3.471s
  user  0m2.956s
  sys   0m0.516s

  # Openssl speed
  $ openssl speed sha1
  Doing sha1 for 3s on 16 size blocks: 12081890 sha1's in 3.00s
  Doing sha1 for 3s on 64 size blocks: 11563950 sha1's in 3.00s
  Doing sha1 for 3s on 256 size blocks: 8375101 sha1's in 3.00s
  Doing sha1 for 3s on 1024 size blocks: 3987643 sha1's in 3.00s
  Doing sha1 for 3s on 8192 size blocks: 678036 sha1's in 3.00s
  OpenSSL 1.0.2g 1 Mar 2016
  built on: reproducible build, date unspecified
  options:bn(64,64) rc4(8x,int) des(idx,cisc,16,int) aes(partial) idea(int) 
blowfish(idx)
  compiler: gcc -I. -I.. -I../include -DOPENSSL_THREADS -D_REENTRANT 
-DDSO_DLFCN -DHAVE_DLFCN_H -Wa,--noexecstack -m64 -DL_ENDIAN -O3 -Wall 
-DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 
-DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DAES_ASM 
-DVPAES_ASM -DBSAES_ASM -DWHIRLPOOL_ASM -DGHASH_ASM -DECP_NISTZ256_ASM
  The 'numbers' are in 1000s of bytes per second processed.
  type 16 bytes 64 bytes 256 bytes 1024 bytes 8192 bytes
  sha1 64436.75k 246697.60k 714675.29k 1361115.48k 1851490.30k

  * autopkgtest failure :

  {Xenial - openssl}
  * Regression in autopkgtest for linux-hwe (ppc64el): test log
  * Regression in autopkgtest for linux-hwe (i386): test log
  * Regression in autopkgtest for linux-hwe (amd64): test log
  * Regression in autopkgtest for linux-gke (amd64): test log
  * Regression in autopkgtest for linux-hwe-edge (ppc64el): test log
  * Regression in autopkgtest for linux-hwe-edge (i386): test log
  * Regression in autopkgtest for linux-hwe-edge (amd64): test log
  * Regression in autopkgtest for linux-aws (amd64): test log

  In this case all the linux-* regressions are failing because the
  autopkgtest script: debian/tests/ubuntu-regression-suite fails if the
  running kernel during the test is different from the the kernel that
  kernel team believe it should run against.

  It compares the 'dpkg-parsechangelog -SVersion' output against the
  version in /proc/version_signature and if they don't match it fails.

  if [ "$sver" != "$rver" ]; then
      echo "ERROR: running version does not match source package" 1>&2
      exit 1
  fi

  Buildlog error:

  autopkgtest [00:45:29]: test ubuntu-regression-suite: [-----------------------
  Source Package Version: 4.8.0-54.57~16.04.1
  Running Kernel Version: 4.4.0-79.100
  ERROR: running version does not match source package
  autopkgtest [00:45:32]: test ubuntu-regression-suite: -----------------------]

  To avoid this failure, the autopkgtest machine would have to run the
  exact same kernel version as expected by each linux-* package.

  * Regression in autopkgtest for postgresql-9.5 (armhf): test log
  ==> The autopkgtest regression seems to be there since "2016-10-17 01:14:36 
UTC" so it's nothing new nor related to this specific SRU.
  http://autopkgtest.ubuntu.com/packages/postgresql-9.5/xenial/armhf

  * Regression in autopkgtest for linux-hwe (armhf): test log
  * Regression in autopkgtest for linux-hwe-edge (armhf): test log
  ==> ubuntu-regression-suite SKIP Test requires machine-level isolation but 
testbed does not provide that

  The debian/test/control is using "isolation-machine" restrictions,
  which prevent the test to run in a schroot/container. The test will
  have better chance to succeed if running inside qemu.

  * Regression in autopkgtest for nodejs (s390x): test log
  ==> This test is failing since 'openssl/1.0.2g-1ubuntu4.3' (2016-09-16 
07:42:14 UTC) prior this SRU.

  {Yakkety - openssl}

  Regression in autopkgtest for mongodb (armhf): test log
  ==> The autopkgtest regression seems to be there since "2016-11-17 19:43:07 
UTC" so it's nothing new nor related to this specific SRU.
  http://autopkgtest.ubuntu.com/packages/mongodb/yakkety/armhf

  Regression in autopkgtest for postgresql-9.5 (armhf): test log        
1.0.2g-1ubuntu9
  ==> The autopkgtest regression seems to be there since "2016-10-21 14:20:53 
UTC" so it's nothing new nor related to this specific SRU.
  http://autopkgtest.ubuntu.com/packages/postgresql-9.5/yakkety/armhf

  {Zesty - openssl}
  none

  [Other Info]

  * Debian Bug :
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861145

  * Upstream PR :
  https://github.com/openssl/openssl/issues/2848

  * Upstream Repository :
  https://github.com/openssl/openssl.git

  * Upstream Commits :
  1aed5e1 crypto/x86*cpuid.pl: move extended feature detection.
  ## This fix moves extended feature detection past basic feature detection 
where it belongs.

  f8418d8 crypto/x86_64cpuid.pl: move extended feature detection upwards.
  ## This commit for x86_64cpuid.pl addressed the problem, but messed up 
processor vendor detection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/openssl/+bug/1674399/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~group.of.nepali.translators
Post to     : group.of.nepali.translators@lists.launchpad.net
Unsubscribe : https://launchpad.net/~group.of.nepali.translators
More help   : https://help.launchpad.net/ListHelp

Reply via email to