On Thu, Aug 2, 2018 at 12:30 PM 'Carl Mastrangelo' via grpc.io < grpc-io@googlegroups.com> wrote:
> It is surprising to see the method name as a String, as Netty takes care > to cache it inside of the MethodDescriptor as an AsciiString. > This is used in the server path, where Netty won't really see the MethodDescriptor; Netty is forced to create the String in order to do a MethodDescriptor lookup from the registry. Kun, it looks like the field should just be removed; it is unused. Am I reading that right? Aside: Interning doesn't seem like a good idea, since there are an unbounded number of these strings (they are user-controlled and arbitrary). Storing this in the HPACK table though would probably work pretty well, if we had the infrastructure to do that. -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+unsubscr...@googlegroups.com. To post to this group, send email to grpc-io@googlegroups.com. Visit this group at https://groups.google.com/group/grpc-io. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/CA%2B4M1oNmK%2BXodxZE2GWzfAZuzrBHjLd6xtxiWWgF7zaRTMS_Zw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
smime.p7s
Description: S/MIME Cryptographic Signature