Yes, I mean NettyTransportFactory.getScheduledExecutorService. offloadExecutor does not solve the problem with eventLoopGroup used as as ScheduledExecutorService. More specifically - eventLoopGroup.schedule() is calling to eventLoopGroup.next().schedule() which is moving a current eventLoop index and making impossible to control 1 to 1 eventLoop to netty transport assignment.
Thanks, Dan On Thursday, June 1, 2023 at 3:51:59 PM UTC-7 sanjay...@google.com wrote: > Comments inline below: > > On Wednesday, May 31, 2023 at 6:24:56 PM UTC-7 dan...@gmail.com wrote: > > Hello, > > I have observed that the ScheduledExecutorService utilized for setting up > deadlines and exiting idle mode is obtained by calling > NettyClientTransport.getScheduledExecutorService, > > > I think you mean NettyTransportFactory.getScheduledExecutorService which > is inside NettyChannelBuilder. > > > which returns an EventLoopGroup instance that was previously set in > NettyChannelBuilder.eventLoopGroup(). > > > Is there a specific rationale behind utilizing the same EventLoopGroup > instance for executing IO tasks and as a ScheduledExecutorService? > > > NettyChannelBuilder also has offloadExecutor which lets a user to set a > custom executor that will be used for (IO) operations that block or are > expensive. > When it is not set the builder will use a static cached thread pool (which > presumably is the same as the one set from eventLoopGroup or the system > default). > > Do you think that addresses your concern? > > > I have identified two disadvantages associated with this approach: > > 1. Developers relinquish control over EventLoop to subchannel assignment, > potentially leading to multiple subchannels sharing the same EventLoop. > 2. The deadline task may end up in the same slow EventLoop, which > subsequently requires its cancellation. > > To tackle these issues, I propose the addition of a setter method for a > custom ScheduledExecutorService within the NettyChannelBuilder. This > enhancement would enable the separate scheduling of tasks while exclusively > utilizing the EventLoopGroup for IO operations. > > Best regards, > Dan > > -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/b941db79-d90b-4975-a282-109321d065d1n%40googlegroups.com.
