Hollis Blanchard <[EMAIL PROTECTED]> writes: > On Feb 20, 2005, at 7:39 AM, Yoshinori K. Okuji wrote: > >> On Sunday 20 February 2005 00:34, Hollis Blanchard wrote: >>> - grub_reboot and grub_halt in util/i386/pc/misc.c are not >>> architecture-specific, so have been moved to util/grub-emu.c. >> >> grub_halt is clearly arch-specific. Look at the definition grub_halt in >> PC. It takes one argument, while the PPC version does not. I expect >> that the same thing might happen in grub_reboot as well. > > Oops, I meant to convert that into using a more generic "flags" > argument, and then "no_apm" becomes one bit in it. How would that be?
And how would the parser work? What if more options have to be added for other archs? I do not have a strong objection against using flags, I am just afraid it might be inadequate and that the current code is easier to maintain. Thanks, Marco _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
