Hollis Blanchard <[EMAIL PROTECTED]> writes:
> Debugging a partition map bug, I was adding more grub_dprintf messages...
> and re-discovered that our printf doesn't handle e.g. "%lx" format strings
> (yet
> gcc requires these when printing longs).
Isn't that hexadecimal?
> * kern/misc.c (grub_vsprintf): Add `longfmt'. If format string
> contains `l' modifier, get a long from va_arg().
You forgot the first line... Please make sure the date you use is the
date you check in. With your previous commit something went wrong.
> if (*fmt && *fmt =='-')
> {
> rightfill = 1;
> fmt++;
> }
> -
> +
> p = (char *) fmt;
> /* Read formatting parameters. */
Please watch out for such stuff. I know it is annoying...
The patch looks fine to me.
Thanks,
Marco
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
