Vincent Pelletier <[EMAIL PROTECTED]> writes: Hi Vincent,
Thanks a lot for your porting work, you are doing a great job! You definitely set the world record GRUB porting. :) Here are some comments on the patch. This patch can be applied after Hollis' patch, which will require some changes in your patches. > Index: include/grub/types.h > =================================================================== > RCS file: /cvsroot/grub/grub2/include/grub/types.h,v > retrieving revision 1.5 > diff -u -p -r1.5 types.h > --- include/grub/types.h 4 Apr 2004 13:46:00 -0000 1.5 > +++ include/grub/types.h 12 Jul 2005 18:51:50 -0000 > @@ -74,11 +74,15 @@ typedef grub_uint64_t grub_addr_t; > typedef grub_uint64_t grub_off_t; > typedef grub_uint64_t grub_size_t; > typedef grub_int64_t grub_ssize_t; > +typedef grub_int64_t grub_intn_t; > +typedef grub_uint64_t grub_uintn_t; > #else > typedef grub_uint32_t grub_addr_t; > typedef grub_uint32_t grub_off_t; > typedef grub_uint32_t grub_size_t; > typedef grub_int32_t grub_ssize_t; > +typedef grub_int32_t grub_intn_t; > +typedef grub_uint32_t grub_uintn_t; > #endif > > /* Byte-orders. */ > Index: include/grub/i386/pc/time.h > =================================================================== > RCS file: /cvsroot/grub/grub2/include/grub/i386/pc/time.h,v > retrieving revision 1.5 > diff -u -p -r1.5 time.h > --- include/grub/i386/pc/time.h 27 Feb 2005 21:19:05 -0000 1.5 > +++ include/grub/i386/pc/time.h 12 Jul 2005 18:51:52 -0000 > @@ -25,6 +25,6 @@ > #define GRUB_TICKS_PER_SECOND 18 > > /* Return the real time in ticks. */ > -grub_uint32_t EXPORT_FUNC (grub_get_rtc) (void); > +grub_uintn_t EXPORT_FUNC (grub_get_rtc) (void); When Hollis' patch is applied, this is not required anymore. > Index: kern/dl.c > =================================================================== > RCS file: /cvsroot/grub/grub2/kern/dl.c,v > retrieving revision 1.10 > diff -u -p -r1.10 dl.c > --- kern/dl.c 14 Feb 2005 18:41:33 -0000 1.10 > +++ kern/dl.c 12 Jul 2005 18:51:52 -0000 > @@ -618,7 +618,10 @@ grub_dl_load (const char *name) > return mod; > > if (! grub_dl_dir) > - grub_fatal ("module dir is not initialized yet"); > + { > + grub_error(0,"module dir is not initialized yet"); > + return 0; > + } Can you explain this? Thanks, Marco _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel