On Aug 14, 2005, at 6:03 PM, Yoshinori K. Okuji wrote:
On Monday 15 August 2005 00:27, Ruslan Nikolaev wrote:
Yesterday I sent patch for mmap support and x86_64 detection. What do
you
think about? I need to known about it becuase I'll be busy this
week...
Ruslan, I would ask for a different function name. Initially I was very
confused as to how/why GRUB was implementing mmap(2), but obviously
that's not really what's going on. Perhaps "grub_multiboot_get_memmap"
instead of "grub_multiboot_mmap"?
The detection code should not be a part of the kernel. You can do this
only
protected mode, right?
(I guess you mean the grub "kern" directory. Calling it "kernel" is a
little confusing because of course GRUB loads kernels...)
Why shouldn't it go there? Where should it go?
I prefer implementing this with inline assembly.
That's quite a lot of inline assembly... why not make it its own
function?
-Hollis
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
