On Thu, Sep 14, 2006 at 08:47:18PM +0200, Marco Gerards wrote:
> Robert Millan <[EMAIL PROTECTED]> writes:
>
> > grub-probefs used to recurse into /dev/.static, then come up with
> > /dev/.static/dev/hda as my root disk, which later fails to pass the
> > pathname-based checks that expect things like /dev/[hsf]d[0-9].
> >
> > 2006-09-14 Robert Millan <[EMAIL PROTECTED]>
> >
> > * util/i386/pc/getroot.c: Don't recurse into dotdirs (e.g. ".static").
>
> There is a double space before "Don't", it should be a single space.
Ok.
> > - if (S_ISDIR (st.st_mode))
> > + if (S_ISDIR (st.st_mode) && ent->d_name[0] != '.')
> > {
> > - /* Find it recursively. */
> > + /* Find it recursively, but avoid dotdirs (like ".static") since they
> > + could contain duplicates, which would later break the
> > pathname-based
> > + check */
>
> This looks fine, but funny. I assume you are using tabs where there
> should be spaces. Can you please check that before committing?
Yep, I had it wrong. Fixed now.
--
Robert Millan
My spam trap is [EMAIL PROTECTED] Note: this address is only intended for
spam harvesters. Writing to it will get you added to my black list.
_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel