Jeff Chua <[EMAIL PROTECTED]> writes: > On Mon, 9 Oct 2006, Hollis Blanchard wrote: > >>> Shall I use '#ifdef __linux__' to include <asm/param.h> only on linux, and >>> '#define COMMAND_LINE_SIZE 255' for non-linux system? >> > 5B> Well, does this number change often? If not, let's just copy it. >> >> If so, then we're screwed anyways because asm/param.h would only match >> the installed kernel's limit, so may not work for other kernel versions. > > You're right. asm/param.h determines the limit. We've read this from > here for linux. > > The idea is that there are users out there who wants to pass quite a > few parameters during boot, and loadlin currently handles this. I'm > passing network address, netmask, broadcast, hostname, modules_to_load > and boot the system up using ramdisk. This allow every system to be > unique and yet able to boot from the same CDROM/image. > > So, another approach is to use "configure --CommandLineSize=1024" to > specify the size, but I thought reading from asm/param.h would be > easier.
I don't like limits that are introduced at compile time. It means that either things break when a kernel with other limits are used. Or that users will get binaries with limits (for example, when using a GRUB 2 package). -- Marco _______________________________________________ Grub-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/grub-devel
