Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Jan 15, 2008 at 01:25:25PM +0100, Marco Gerards wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> > On Mon, Jan 14, 2008 at 09:32:39PM +0100, Yoshinori K. Okuji wrote: >> >> On Monday 14 January 2008 15:10, Robert Millan wrote: >> >> > As subject says. Based on suggestions from Vesa. >> >> >> >> Why do you want to use a nested function? >> > >> > No special reason; just to restrict the namespace use to the scope where >> > it'll be needed, and avoid passing of parameters (offset, timeout). >> > >> > I'm fine with moving it out if that's preferred. >> >> If it doesn't uglify your code, that's usually a better thing to do. > > Ok, here's a new patch.
Here's a review :) > -- > Robert Millan > > <GPLv2> I know my rights; I want my phone call! > <DRM> What use is a phone call, if you are unable to speak? > (as seen on /.) > > > * normal/menu.c (run_menu): Move timeout message from here ... > (print_timeout): ... to here. > (run_menu): Use print_timeout() once during initial draw to print > the whole message, and again in every clock tick to update only > the number of seconds. > > diff -x '*~' -x configure -x config.h.in -ur grub2/normal/menu.c > flickery/normal/menu.c > --- grub2/normal/menu.c 2008-01-05 13:10:28.000000000 +0100 > +++ flickery/normal/menu.c 2008-01-15 13:37:54.000000000 +0100 > @@ -308,12 +308,27 @@ > return entry; > } > > +void > +print_timeout (int timeout, int offset, int second_stage) please make this function static. Otherwise, I do not see any problems. -- Marco _______________________________________________ Grub-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/grub-devel
