On Fri, Feb 29, 2008 at 09:33:13AM +0100, Fabian Greffrath wrote: > >For this one, I think it'd be much better to rework 10_hurd so that code is > >shared, rather than duplicating the whole blurb. > > Yes, we could source out the complete linux/hurd kernel-adding blurbs > into an external shell library that is shared with 10_* and 30_os-prober. > > However, please don't forget these are two different things. 10_* look > on / and /boot, while os-prober looks on all *other* partitions.
For 10_linux it isn't that important since the boot parameters are so small, it's 10_hurd that has more reusable stuff (that big blurb). > >Do you plan to do that later? > > Not a concrete plan yet, However, we should first get thinks *working* > before we care about cosmetics, IMHO. ;) In that case maybe it's better to leave Hurd support for later, than duplicating the whole thing. > >Maybe it's better to echo something here, otherwise it gives the impression > >OS FooBar was just detected and properly added. > > Definitely. I'll add a short warning message. > > Furthermore, I am going to modify the script to immediately 'exit 0' > if it turns out it misses the tools required to update the boot menu > (i.e. os-prober, linux-boot-prober, grub-probe (>= 20080228)). These > tests are spread all over the script at the moment. Ok. > PS: Shouldn't 30_os-prober be an upstream feature of os-prober?! Not sure about that. My initial intention was that in general one could plug in scripts from other system components, but often the code in them depends on many update-grub interfaces which makes it likely to break if something is changed. For now only very simple add-ons exist (memtest86, invaders...). But this one will probably end up being more intermangled with other GRUB parts (see that we're already discussing how to reduce code duplication with 10_hurd). I'd suggest putting it in GRUB, at least for now, if that is fine with you. -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What use is a phone call… if you are unable to speak? (as seen on /.) _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel