On Fri, 13 Jun 2008 00:43:31 +0200 Javier Martín <[EMAIL PROTECTED]> wrote:
> Hi there, I checked your comment, reread the GNU coding guidelines and > fixed some things (stated below the relevant parts of your message). > Here is the new version of the patch. > > El jue, 12-06-2008 a las 16:31 -0400, Pavel Roskin escribió: > > Please don't add any trailing whitespace. Line in the patch that > > start with a plus should not end with a space or a tab. > I could not find the line you were referring to. I could only find one > line starting with a plus (in install_int13_handler), but it does not > end with a space/tab. However, I did find one trailing tab after a > comment, and removed it. I think Pavel meant the lines added by the patch, i.e., beginning with a plus in the patch, not in the original source. Here's an illustration to help find and visualize the invisible trailing whitespace: [EMAIL PROTECTED] ~ $ perl -ne '/^\+.* +$/ and y/ \t/_~/ and print' /home/cdb/drivemap.patch +______else_if_(mapto_==_mapfrom)__/*_Reset_to_default_*/______ +______ +______/*_Save_the_pointer_to_the_old_int13h_handler_*/____ +______ +VARIABLE(grub_drivemap_int13_handler_base)__ +__ +__push_%bp__ +___________(grub_err_t_(*hook)_(void),_int_abort_on_error);_ +__ I highly recommend running indent --no-tabs on your source code, as long as it doesn't cause too many spurious changes to pre-existing code. This should take care of most formatting inconsistencies and frees you a little but from concerning yourself with trivial details. Colin
signature.asc
Description: PGP signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel