On Mon, Jun 30, 2008 at 02:28:24AM +0000, Lucas Gadani wrote: > Hello, > > This is my first patch for GRUB, and I haven't found any coding > styles/formatting, nor developer documentation, so, if there's > something wrong, please, forgive me and point me to the right > direction. > > Current implementation of the chainloading code does not work, cause > it reads the partition table from the first sector of the root device, > and the root device does not contain partition information. I've > changed the way partition table are loaded, keeping a copy of the > partition entry in grub_partition_t structs data field, and just > loading this information in the correct address when chainloading. > I've also changed the logical partitions start address to point to the > actual disk sector, instead of pointing to the sector relative to the > beginning of the extended partition, so we can now boot into logical > partitions (for example, syslinux doesn't boot if the partition table > doesn't map to the correct disk sector). > > Any comments are appreciated.
Looks like it increases pc.mod code to store information that is only useful to the chainloader. Is there a reason for not having the chainloader retrieve it? (note that for disk access we have a cache) -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What good is a phone call… if you are unable to speak? (as seen on /.) _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel