On Mon, Aug 04, 2008 at 02:31:28AM +0200, Felix Zielcke wrote: > I just tried to compile the Debian packages with the currently SVN > version and it failed: > > cc -Iloader/i386/efi -I/home/fz/grub/grub2-1.96+20080804/loader/i386/efi -I. > -Iinclude -I/home/fz/grub/grub2-1.96+20080804/include -Wall -W -Wall -W > -Wshadow -Wpointer-arith -Wmissing-prototypes -Wundef > -Wstrict-prototypes -g -Os -m64 -fno-stack-protector -mno-stack-arg-probe > -fno-builtin -m64 -MD -c -o _linux_mod-loader_i386_efi_linux.o > /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c > In file included from > /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c:34: > /home/fz/grub/grub2-1.96+20080804/include/grub/pci.h:48:26: error: > grub/cpu/pci.h: No such file or directory > /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c: In function > 'grub_find_video_card': > /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c:471: warning: > implicit declaration of function 'grub_pci_read'
So we have grub/i386/pci.h but not grub/x86_64/pci.h. This is my fault, but I think it's too easy to make mistakes with this <grub/i386/> vs <grub/x86_64/> duplicity. Furthermore, I had a look and some of the x86_64 versions are just stubs that include the i386 one. Why don't we handle this like Linux? They ship a single directory and use #ifdefs where appropiate. That enforces consistency in the dir layout. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel