On Fri, Aug 08, 2008 at 01:52:07AM +0800, Bean wrote:
> date 10-05-13-15
> Oct 5, 13:15
Nice. Btw this will be real fun for translators when we have gettext
support ;-)
> + if (n < 0)
> + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date");
> +
> + switch (pos)
> + {
> + case 0:
> + if ((n < 1) || (n > 12))
> + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date");
> +
> + mask |= GRUB_DATETIME_SET_MONTH;
> + datetime.month = n;
> + break;
> +
> + case 1:
> + if ((n < 1) || (n > 31))
> + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date");
> +
> + mask |= GRUB_DATETIME_SET_DAY;
> + datetime.day = n;
> + break;
> +
> + case 2:
> + if (n > 23)
> + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date");
> +
> + mask |= GRUB_DATETIME_SET_HOUR;
> + datetime.hour = n;
> + break;
> +
> + case 3:
> + if (n > 59)
> + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date");
> +
> + mask |= GRUB_DATETIME_SET_MINUTE;
> + datetime.minute = n;
> + break;
> +
> + case 4:
> + if (n > 99)
> + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date");
Since those grub_error calls are always the same, I think it'd be a good
idea to group them together in a "fail:" section to save space.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel
