On Mon, 2009-04-13 at 16:16 +0200, Robert Millan wrote: > Hi Pavel, > > On Mon, Apr 06, 2009 at 11:34:03AM -0400, Pavel Roskin wrote: > > Hello! > > > > This is an attempt to fix all issues with the video mode handling in the > > new Linux loader. > > Please, in general, when you modify code that has been actively worked on > by someone, try to get that person involved.
I tried, but probably not hard enough. Sorry. > > The default VGA mode is now GRUB_LINUX_VID_MODE_NORMAL, not the mode of > > the kernel we tried to load before. > > Ok, BUT if we're already in vesa mode, and we know it works (since we're using > it), there's no point in wasting time only to get a worse mode. Maybe we should introduce another macro, e.g. GRUB_LINUX_VID_MODE_CURRENT, recognize it in the loader and default to it. > We should just make sure subsequent calls to "linux" command override the > previous one. Yes, failed loading of one kernel should not affect loading of another kernel. That was the most annoying bug, and I hope it's fixed now. > > Finally, "vga=ask" is now recognized. > > With the new loader, Linux' 16-bit entry code is no longer responsible for > setting vesa modes, therefore vga=ask can't work. There's no point in > recognizing it (except to warn the user). I agree. Generally, "vga=random_string" causes an error now. Perhaps any unrecognized values of "vga" should cause a warning, not an error. -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel