On Wed, 2009-04-15 at 00:45 +0900, Yoshinori K. Okuji wrote: > On Saturday 11 April 2009 22:16:58 Pavel Roskin wrote: > > Quoting "Yoshinori K. Okuji" <ok...@enbug.org>: > > > "test -n" should be avoided. Maybe this is not necessary nowadays, but my > > > old lesson was to use "test x$target_alias != x" instead for portability. > > > Well, "!=" was not very portable, either, maybe. > > > > I believe both "-n" and "!=" are found in Autoconf sources that are > > turned into configure scripts. Anyway, I'll use the syntax you want. > > Even if this looks obsolete, I think it is better to follow the > chapter "Limitations of Builtins" in the autoconf manual:
Thanks. The Autoconf code I was referring to didn't involve any possibility of pathological arguments. But we are dealing with user input here (target_alias comes from the command line), so you are right, it's better to err on the safe side. -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
