On Fri, Jun 05, 2009 at 03:24:09AM +0200, Vladimir 'phcoder' Serbinenko wrote: > > gcc -Icommands -I./commands -I. -I./include -I./include -Wall -W -Wall -W - > > Wshadow -Wpointer-arith -Wmissing-prototypes -Wundef - > > Wstrict-prototypes -g -Os -falign-jumps=1 -falign-loops=1 > > -falign-functions=1 > > -m32 -fno-stack-protector -mno-stack-arg-probe -fno-builtin -mrtd > > -mregparm=3 > > -m32 -Werror -Wall -MD -c -o search_mod-commands_search.o commands/search.c > > cc1: warnings being treated as errors > > commands/search.c: In function 'search_fs': > > commands/search.c:42: error: generating trampoline in object (requires > > executable stack) > > commands/search.c: In function 'grub_cmd_search': > > commands/search.c:105: error: generating trampoline in object (requires > > executable stack) > > make[1]: *** [search_mod-commands_search.o] Error 1 > > > > $ gcc --version > > gcc (Gentoo 4.3.3-r2 p1.1, pie-10.1.5) 4.3.3 > > > This is because of commit 2243 by Robert Millan. The commit was about > floppy probing but also added -Wall -Werror to search.mod > I myself stepped on this mine once with adding -Wall -Werror to my xnu module. > I'll revert this change (only -Werror, not the rest of commit) as it > causes build error for all gentoo users. Sorry, Robert, but we can't > enable -Werror and still have nested functions. I don't think we > should use -Werror at all because different compilers, versions or > modifications of same compiler cause different warnings and imho > maintaintaining cost is too high and breaks are too frequent. Or > perhaps we can enable -Werror only on some compilers? Or perhaps > anyone has a better idea
Unfixed warnings have given us MUCH worse problems than build failures. I'm talking countless hours of debugging here. Why exactly does gcc generate a warning because of nested functions? Is there no way to fix this? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel