Quoting Vladimir 'phcoder' Serbinenko <phco...@gmail.com>:
On Mon, Jun 8, 2009 at 4:10 AM, Pavel Roskin<pro...@gnu.org> wrote:
Also, it would be great
if you specify, which exactly problems the patch fixes.
You missed that part because it was in the previous drivemap thread.
It would be helpful if you summarize the changes in the patch
description. That would make it easier to review the patch for those
who don't have time to go through the list archives.
It fixes 2 problems: grub2 passes incorrect boot number and %dl not
being restored after int 0x13
As for the later, it should be documented in comments in
drivemap_int13h.S. The code is very unclear with regard to what
exactly is being restored.
Also, I'll appreciate if you avoid adding trailing whitespace in your
patches. The changes to drivemap_int13h.S also introduce pointless
spaces before some tabs.
--
Regards,
Pavel Roskin
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
