On Wed, Jul 22, 2009 at 10:42:54AM -0700, Joe Auricchio wrote: >> >> So perhaps this can be solved simpler by replacing grub_malloc with >> grub_zalloc ? > > I saw the zalloc commit and thought the same thing! :D I'll test it. But > fg_color and bg_color must be set to the screen's current colors, which > may not be zero. > > I just discovered that > - this patch to grub_virtual_screen_setup() > - scroll_up() line 579 /* Clear last line in text buffer. */, and > - grub_virtual_screen_cls() > do the same thing. > > An opportunity to refactor? I'll look into this.
Hi, Note that the initial patch was committed due to lack of coordination (there's been a period in which we've been sloppy due to lack of leadership, but this won't happen again). Nevertheless, the initial approach is probably not correct; my impression is that it should be using grub_zalloc() instead. If you're still interested, I'd appreciate if you could fix that. Thanks -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
