On Mon, Nov 16, 2009 at 08:09:56PM +0100, Jordi Mallach wrote:
>
> Also, as something merely cosmetic, messages.pot could be $(PACKAGE).pot,
> which is more common.
Changed in my gettext branch.
> > > +#define _(str) gettext(str)
> > And I'm not sure if this is the right place to define _. Isn't there
> > a system-wide definition?
>
> This, and others, sometimes go in a common .h to avoid duplication. Many
> grub utilities are going to add this kind of stuff.
I wonder where would we put this. Is there any convention?
> > > + textdomain ("grub");
> > What's the usual way to handle this? TEXTDOMAIN macro?
>
> As Colin said, $PACKAGE is common.
> I haven't tested this patch yet, but I'm not sure if a bindtextdomain()
> call is needed here too.
This requires LOCALEDIR. Should we add po.m4 in order to get this, or
just define it ourselves?
> The rest looks good, given there's no automake.
We have aclocal now (in my branch). Is gettext.m4 usable to us?
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
