On Sun, Nov 22, 2009 at 11:24:14PM +0000, Carles Pina i Estany wrote: > > discussed in irc with phcoder: no changes here because would be a caller > bug. Some day I will take a look on a possible callers that are not > resetting grub_errno after functions that are setting up (so can lead to > problems later)
Yes. We really need more quality checks, but not at the expense of size as Vladimir points out. Another possibility would be something automated like the "fortity source" feature of glibc + gcc, as recently enabled in some OSes. Unit tests are also helpful (there was a patch sent recently, which implements a "make check" command, but there were some issues and still got no response). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
