On Mon, Nov 23, 2009 at 05:28:51PM +0100, Jordi Mallach wrote: > > > - grub_printf ("\nPress any key to continue..."); > > > + grub_printf (_("\nPress any key to continue...")); > > > > I'm not sure if the spaces and newlines here would be a problem. Jordi, > > any comment? > > Not a big issue in this case. However, it makes it difficult to reuse these > strings, ie we can end up having 3 different strings: > - \nPress any key to continue... > - Press any key to continue... > - Press any key to continue...\n > > which makes it easy to make different translations for the same string if the > translator isn't careful.
Thanks Jordi. This made me think, it also makes GCC allocate the string 3 times. So one more reason to handle those! -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel