Hi,
On Dec/07/2009, Carles Pina i Estany wrote:
> So I would apply your patch, after understanding that it's only for
one more thing Colin. What do you think to not apply your patch and
apply the attached patch?
It force that the argument 1 of _ and N_ is a c-format (in this way
appears in grub.pot). This is, IMO, correct approach. And then msgfmt -c
checks the number of arguments.
If other projects are not using this approach they could have some
reason, like _("File") is a menu label and not a C format string. In
this cases, if this happens in Grub it's not making things worse.
Using it we should have all checks about the number of arguments and we
are not programming warning oriented.
If it's a linguism and wide accepted to do in the other way I personally
don't have any strong objection.
--
Carles Pina i Estany
http://pinux.info
=== modified file 'Makefile.in'
--- Makefile.in 2009-11-30 01:25:57 +0000
+++ Makefile.in 2009-12-07 23:28:49 +0000
@@ -477,7 +477,7 @@ genkernsyms.sh: genkernsyms.sh.in config
$(SHELL) ./config.status
$(srcdir)/po/$(PACKAGE).pot: po/POTFILES po/POTFILES-shell
- cd $(srcdir) && $(XGETTEXT) --from-code=utf-8 -o $@ -f $< --keyword=_ --keyword=N_
+ cd $(srcdir) && $(XGETTEXT) --from-code=utf-8 -o $@ -f $< --keyword=_ --keyword=N_ --flag=N_:1:c-format --flag=_:1:c-format
cd $(srcdir) && $(XGETTEXT) --from-code=utf-8 -o $@ -f po/POTFILES-shell -j --language=Shell
$(foreach lang, $(LINGUAS), $(srcdir)/po/$(lang).po): po/$(PACKAGE).pot
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
