On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > +char *EXPORT_FUNC(grub_asprintf) (const char *fmt, ...) > + __attribute__ ((format (printf, 1, 2)));
It's very confusing that you've made grub_asprintf have a dramatically different interface from asprintf. Perhaps you could call this grub_xasprintf instead? (Although I notice that it doesn't die when malloc fails, but merely returns NULL.) > +char *EXPORT_FUNC(grub_avsprintf) (const char *fmt, va_list args); The conventional spelling is vasprintf, not avsprintf. -- Colin Watson [cjwat...@ubuntu.com] _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel