On Wed, Jan 06, 2010 at 09:22:15PM -0800, Jordan Uggla wrote: > On Tue, Jan 5, 2010 at 3:08 AM, Colin Watson <[email protected]> wrote: > >> 2: Setting GRUB_DEFAULT=saved in /etc/default/grub also enables savedefault > >> functionality. There are many people who would want to use grub-reboot and > >> grub-set-default without savedefault. The second patch adds a separate > >> variable, GRUB_SAVEDEFAULT, for enabling savedefault. > > > > How would this interact with setting GRUB_DEFAULT to something other > > than "saved", and doesn't 00_header.in also need to be changed to > > actually use the saved entry (it won't be used unless you have > > GRUB_DEFAULT=saved)? > > That's correct. Perhaps GRUB_SAVEDEFAULT=true should imply GRUB_DEFAULT=saved? > > ( if [ "x${GRUB_DEFAULT}" = "xsaved" -o x${GRUB_SAVEDEFAULT} = > "xtrue" ] ; then GRUB_DEFAULT='${saved_entry}' ; )
I've left them independent for now, since I'm not sure I've thought this through properly. (For instance you might want to change the saved entry but not use it right away for some reason?) > > In my mind, GRUB_DEFAULT was overloaded for this for a good reason; but > > perhaps I'm simply not understanding what you mean, so would you mind > > explaining further how you'd like to see the whole thing laid out? > > I am not set on a single layout ( I'd like input from others on > exactly how this should work ). But I do think that it should be > possible to use utilities like grub-set-default and grub-reboot > without also enabling savedefault. As an example use case: [...] Thanks for the explanation. I agree now, and have committed your patch. -- Colin Watson [[email protected]] _______________________________________________ Grub-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/grub-devel
